Bump LDK to 0.3.0-beta1 - #1008
Conversation
|
👋 Thanks for assigning @jkczyz as a reviewer! |
Track the first LDK 0.3 beta and its matching payment-instructions revision. Preserve Esplora configuration across the client versions and expose splice negotiation only to local contributors, as defined by the beta API. Co-Authored-By: HAL 9000
528b611 to
dce81a1
Compare
| /// | ||
| /// The caveat described above the `total_fee_earned_msat` field applies here as well. | ||
| outbound_amount_forwarded_msat: Option<u64>, | ||
| outbound_amount_forwarded_msat: u64, |
There was a problem hiding this comment.
AI: This still exposes only the aggregate forwarded amount. LDK 0.3 adds amount_msat to each HTLCLocator so callers can attribute multi-HTLC and trampoline forwards to individual channels, but our From<LdkHtlcLocator> conversion drops it. Could we add amount_msat: Option<u64> to the local locator, copy it during conversion, and persist it under TLV 7? Making it optional preserves compatibility with existing serialized events.
There was a problem hiding this comment.
Just a drive-by, can be done any time in a later PR
There was a problem hiding this comment.
Just a drive-by, can be done any time in a later PR
Said follow-up: #1021
4 participants
Track the first LDK 0.3 beta and its matching payment-instructions revision. Preserve Esplora configuration across the client versions and expose splice negotiation only to local contributors, as defined by the beta API.
Co-Authored-By: HAL 9000